Skip to content

Fix position:relative not supported on <tr> in webkit (safari) #5431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 15, 2024
Merged

Fix position:relative not supported on <tr> in webkit (safari) #5431

merged 1 commit into from
Nov 15, 2024

Conversation

@MananTank
Copy link
Member

@MananTank MananTank commented Nov 15, 2024 •
edited by pr-codex bot
Loading

We use position:relative on tr to contain the absolutely position anchor link inside - to make the whole row clickable, but that does not work on webkit ( safari )

Relevant article on the topic:
https://mtsknn.fi/blog/relative-tr-in-safari/

PR-Codex overview

This PR focuses on enhancing the table components across various files by introducing a linkBox prop, which allows rows to be clickable. This improves user interaction by enabling navigation directly from table rows.

Detailed summary

  • Added linkBox prop to several TableRow components.
  • Modified className attributes to include cursor-pointer for better UX.
  • Updated TWTable to accept bodyRowLinkBox prop.
  • Enhanced example stories to demonstrate clickable rows in tables.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented Nov 15, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 15, 2024 8:24am
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Nov 15, 2024 8:24am
thirdweb_playground ⬜️ Skipped (Inspect) Nov 15, 2024 8:24am
wallet-ui ⬜️ Skipped (Inspect) Nov 15, 2024 8:24am

@vercel vercel bot temporarily deployed to Preview – docs-v2 November 15, 2024 07:55 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground November 15, 2024 07:55 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui November 15, 2024 07:55 Inactive
@changeset-bot
Copy link

changeset-bot bot commented Nov 15, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 5585def

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@graphite-app
Copy link
Contributor

graphite-app bot commented Nov 15, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@MananTank MananTank marked this pull request as ready for review November 15, 2024 07:55
@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Nov 15, 2024
@MananTank MananTank added the hotfix This pull request should be prioritized in the merge queue. label Nov 15, 2024 — with Graphite App
@MananTank Graphite App
Copy link
Member Author

MananTank commented Nov 15, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codecov
Copy link

codecov bot commented Nov 15, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.50%. Comparing base (10ca0bc) to head (5585def).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #5431   +/-   ##
=======================================
  Coverage   45.50%   45.50%           
=======================================
  Files        1071     1071           
  Lines       55718    55718           
  Branches     4032     4032           
=======================================
  Hits        25357    25357           
  Misses      29674    29674           
  Partials      687      687
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 10ca0bc
packages 40.61% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@MananTank MananTank changed the title Fix position:relative not supported on <tr> in webkit Fix position:relative not supported on <tr> in webkit (safari) Nov 15, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Nov 15, 2024 •
edited
Loading

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 44.8 KB (0%) 896 ms (0%) 549 ms (+44.1% 🔺) 1.5 s
thirdweb (cjs) 105.11 KB (0%) 2.2 s (0%) 795 ms (+26.1% 🔺) 2.9 s
thirdweb (minimal + tree-shaking) 5.72 KB (0%) 115 ms (0%) 226 ms (+739.81% 🔺) 341 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 88 ms (+1504.42% 🔺) 98 ms
thirdweb/react (minimal + tree-shaking) 18.79 KB (0%) 376 ms (0%) 335 ms (+299.08% 🔺) 711 ms

@graphite-app
Copy link
Contributor

graphite-app bot commented Nov 15, 2024 •
edited
Loading

Merge activity

@MananTank
Fix position:relative not supported on <tr> in webkit (safari) (#5431)
5585def 
We use position:relative on tr to contain the absolutely position anchor link inside - to make the whole row clickable, but that does not work on webkit ( safari )

Relevant article on the topic:
https://mtsknn.fi/blog/relative-tr-in-safari/
@MananTank MananTank force-pushed the 11-15-fix_position_relative_not_supported_on_tr_in_webkit branch from 884ee36 to 5585def Compare November 15, 2024 08:21
@vercel vercel bot temporarily deployed to Preview – wallet-ui November 15, 2024 08:21 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground November 15, 2024 08:21 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 November 15, 2024 08:21 Inactive
@graphite-app graphite-app bot merged commit 5585def into main Nov 15, 2024
30 of 31 checks passed
@graphite-app graphite-app bot deleted the 11-15-fix_position_relative_not_supported_on_tr_in_webkit branch November 15, 2024 08:24
@vercel vercel bot temporarily deployed to Production – docs-v2 November 15, 2024 08:25 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui November 15, 2024 08:25 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb_playground November 15, 2024 08:25 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jnsdls jnsdls jnsdls approved these changes

@joaquim-verges joaquim-verges Awaiting requested review from joaquim-verges

Assignees

No one assigned

Labels

Dashboard Involves changes to the Dashboard. hotfix This pull request should be prioritized in the merge queue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MananTank @jnsdls